Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGRDBES discussion needed: pooling design-related validation tests into a single function #67

Open
nmprista opened this issue Oct 12, 2022 · 3 comments
Labels
2_preparation Generating probabilities and Zero's, subsetting species 3_estimation Estimation functions help wanted Extra attention is needed

Comments

@nmprista
Copy link
Contributor

There is a need for function that aggregates the core design-related validation rules ahead of design estimation. This to avoid multiple independent developments of the same tests in different functions and allow for quick updates of all relevant tests if/when guidelines are updated.

E.g., is numSampled necessarily equal to nrows? this might change depending on guidelines on new examples -> it will be time-consuming to find and update all tests in all functions that might contact. Having all tests aggregated in a function would simplify the updates.

@nmprista nmprista added 2_preparation Generating probabilities and Zero's, subsetting species 3_estimation Estimation functions labels Oct 12, 2022
@rix133 rix133 added the help wanted Extra attention is needed label Oct 14, 2022
@nmprista
Copy link
Contributor Author

@rix133 @davidcurrie2001 is this still relevant?

@davidcurrie2001
Copy link
Contributor

Possibly - do you have examples of functions that are currently doing these types of checks?

@rix133
Copy link
Contributor

rix133 commented Oct 14, 2024

Reusing previous tests is OK but there is no need to restrict people to use this approach. Umbrella (integration) tests are good to use but having simple unrelated tests as well is also good to ensure consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2_preparation Generating probabilities and Zero's, subsetting species 3_estimation Estimation functions help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants