Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doDBErawObj #58

Open
mrska opened this issue Sep 17, 2020 · 1 comment
Open

doDBErawObj #58

mrska opened this issue Sep 17, 2020 · 1 comment
Assignees

Comments

@mrska
Copy link
Collaborator

mrska commented Sep 17, 2020

Hi

You can find doDBErawObj function in my personal folder:
https://github.com/ices-eg/WK_RDBES/tree/master/WKRDB-EST2/subGroup1/funs

If time allows I will add some more checks, stops and warnings to it

Best,
Marta

@rix133
Copy link
Contributor

rix133 commented Sep 18, 2020

Testing:

  • I cant identify an example expected input and output

I would suggest to run a lint check on a file before each commit. The commad for this file would be:
lintr::lint("./WKRDB-EST2/subGroup1/funs/doDBErawObj.R",linters=lintr::with_defaults(object_name_linter=lintr::object_name_linter(styles = "camelCase")))

Issues identified by running linter:

  • Lines should not be more than 80 characters.
  • Trailing whitespace is superfluous.
  • Use <-, not =, for assignment.
  • Variable and function name style should be camelCase.
  • Only use double-quotes.
  • Do not place spaces around code in parentheses or square brackets.
  • Place a space before left parenthesis, except in a function call.
  • There should be a space between right parenthesis and an opening curly brace.
  • Commas should always have a space after.
  • no visible binding for global variable ‘allRequiredTables’
  • Commented code should be removed.
  • Put spaces around all infix operators.
  • Avoid 1:length(...) expressions, use seq_len.
  • no visible binding for global variable ‘SL’
  • no visible binding for global variable ‘VD’

Issues identified by running devtools::check():

  • no visible global function definition for 'choose.dir'
  • no visible global function definition for 'read.csv'
  • no visible binding for global variable 'allRequiredTables'
  • no visible binding for global variable 'SL'
  • no visible binding for global variable 'VD'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants