Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default behaviour of the Unblinder when calculating limits #44

Open
JannisNe opened this issue May 21, 2021 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@JannisNe
Copy link
Collaborator

Describe the bug
The injection time is needed to multiply it with the mean luminosity to get the mean energy emitted in neutrinos. The Unblinder calculates this injection time using TimePDF.raw_injection_time() which gives the overlap of the source with the dataset.

Expected behavior
This is an at least controversial way of doing it since for example for a box time pdf we would rather want the box length and not the overlap of the sources with the dataset.

Solution
We could define a property of the TimePDF`` called maybe length``` that return the injection length. This could then be used by the Unblinder.

@JannisNe JannisNe self-assigned this May 21, 2021
@JannisNe JannisNe added the enhancement New feature or request label May 21, 2021
@mlincett
Copy link
Collaborator

I think this issue is now obsolete as the calculation of the energy in the source frame is no longer supported after #236.

Shall we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants