Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use black 2024 #347

Open
JannisNe opened this issue Mar 7, 2024 · 5 comments
Open

use black 2024 #347

JannisNe opened this issue Mar 7, 2024 · 5 comments
Assignees
Labels
dependencies Pull requests that update a dependency file wish list Desireable but not urgent

Comments

@JannisNe
Copy link
Collaborator

JannisNe commented Mar 7, 2024

For now black version 2023 is pinned in pyproject.toml and #346 also pins it in the CI job. At some point we can switch to newer formatting. Maybe when people are not in the middle of analyses.

@JannisNe JannisNe added wish list Desireable but not urgent dependencies Pull requests that update a dependency file labels Mar 7, 2024
@JannisNe JannisNe self-assigned this Mar 7, 2024
@mlincett
Copy link
Collaborator

mlincett commented Mar 7, 2024

We could also consider switching to ruff (although that can potentially do much more linting).

@robertdstein
Copy link
Member

Can I suggest something like this: https://github.com/winter-telescope/wintertoo/blob/main/.github/workflows/black.yml

Basically, install black via pip/poetry rather than using the pre-built github action. That forces the two versions to always be aligned.

@robertdstein
Copy link
Member

The advantage is that dependabot can then do the updating for you

@mlincett
Copy link
Collaborator

mlincett commented Mar 7, 2024

Can I suggest something like this: https://github.com/winter-telescope/wintertoo/blob/main/.github/workflows/black.yml

Basically, install black via pip/poetry rather than using the pre-built github action. That forces the two versions to always be aligned.

I did that in the past for flarestack. Then I recall the upstream black action had been updated to pick up the black version from the repository, so I reverted the workflow to use the action. Not sure why the behaviour changed once again, but I agree that is better to run black ourselves from within the setup.

@JannisNe
Copy link
Collaborator Author

So future todo: run black manually and use poetry version from pyproject.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file wish list Desireable but not urgent
Projects
None yet
Development

No branches or pull requests

3 participants