Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename scratch directory and data directory #293

Open
mlincett opened this issue Aug 17, 2023 · 2 comments
Open

Rename scratch directory and data directory #293

mlincett opened this issue Aug 17, 2023 · 2 comments

Comments

@mlincett
Copy link
Collaborator

Following up on #292 I would propose to rename the following:

  • flarestack__data to flarestack_cache or flarestack_workdir; so there is no confusion with FLARESTACK_DATASET_DIR.
  • FLARESTACK_SCRATCH_DIR to SCRATCH_DIR, so it is clear that SCRATCH_DIR can be shared since a dedicated directory will be created inside.
@JannisNe
Copy link
Collaborator

I like it. It is a breaking change and I would suggest including a version bump to a new subversion already in the PR so that we can create a tag and a new release right away after merging. I guess #292 will come afterward and as such will be a bump to another patch.

@robertdstein
Copy link
Member

I agree it's a good idea and just bump to v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mlincett @robertdstein @JannisNe