Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Report the not yet implemented correctness metrics results to be based on 0 measurements in reports #13

Open
wtoorop opened this issue Jun 11, 2024 · 3 comments

Comments

@wtoorop
Copy link
Contributor

wtoorop commented Jun 11, 2024

Currently doing the queries for the Correctness metrics are implemented, and aggregation of the processed measurements is implemented, but processing the Correctness measurements is not yet fully implemented. That this is still a work in progress, which is clearly mentioned in the README.md.

Because aggregation is already implemented for all metrics (including Correctness) in report_creator.py, the reported correctness metrics currently always shows up as 100% correct, even though they are not actually performed. Perhaps for clarity they should be left out in reports (or should only enabled with a flag) until implementation of the correctness measurement is done. What do you think?

@paulehoffman
Copy link
Contributor

RSSAC047 says that reports will include correctness. Instead of not reporting the (bogus) 100%, it would be better if the reports say something like "This is being reported as required by RSSAC047, but the result is possibly wrong". Please consult your sponsors on that wording.

@wtoorop
Copy link
Contributor Author

wtoorop commented Jun 11, 2024

RSSAC047 says that reports will include correctness. Instead of not reporting the (bogus) 100%, it would be better if the reports say something like "This is being reported as required by RSSAC047, but the result is possibly wrong". Please consult your sponsors on that wording.

In this case I want to discuss the RSSAC047v2 initial implementation with the implementer. I don't want to change RSSAC047v2 directions, I'm merely noticing that an untruth is being reported. I believe reporting an untruth is also not following RSSAC047v2 intentions.

One way to still report on the Correctness metrics is to report "pass" but report 0 as the number of measurements on which that is based. That would match reality and also follow RSSAC047v2 to the letter. What do you think?

@paulehoffman
Copy link
Contributor

Reporting the untruth is indeed not following the intention of RSSAC047, but I think not including the false report is further from the requirements.

I like the idea of reporting the number of measurements as 0!

@wtoorop wtoorop changed the title Suggestion: Leave out correctness metrics results in reports Suggestion: Report correctness metrics results to be based on 0 measurements in reports Jun 27, 2024
@wtoorop wtoorop changed the title Suggestion: Report correctness metrics results to be based on 0 measurements in reports Suggestion: Report the not yet implemented correctness metrics results to be based on 0 measurements in reports Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants