Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update excluded list for extended.openjdk #619

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

WilburZjh
Copy link
Contributor

Signed-off-by: Jinhang Zhang [email protected]

@WilburZjh
Copy link
Contributor Author

@pshipton
Copy link
Member

@alon-sh for review

@llxia
Copy link

llxia commented Oct 13, 2022

@alon-sh could you please review the PR when you have time? Thanks

@alon-sh
Copy link
Contributor

alon-sh commented Oct 13, 2022

the first test is fine, the second test that is excluded:

sun/rmi/rmic/manifestClassPath/run.sh                               https://github.com/ibmruntimes/openj9-openjdk-jdk8/issues/611   linux-x64

@WilburZjh could you give more details on why is this test failing and why should it be excluded rather then fixed?

@WilburZjh
Copy link
Contributor Author

the first test is fine, the second test that is excluded:

sun/rmi/rmic/manifestClassPath/run.sh                               https://github.com/ibmruntimes/openj9-openjdk-jdk8/issues/611   linux-x64

@WilburZjh could you give more details on why is this test failing and why should it be excluded rather then fixed?

This test failed due to it uses Success "$java" ${TESTVMOPTS} -Djava.ext.dirs="jars" -cp . Main in the test. -Djava.ext.dirs="jars" will only load the content from the jar folder without loading the security jar files under $JAVA_HOME/lib/ext. $JAVA_HOME/lib/ext contains the security provider information. That's the reason why this test can't find the SunPKCS11-NSS-FIPS provider. Once I expand this jvm options to Djava.ext.dirs="jars:/home/jenkins/workspace/Grinder_FIPS/openjdkbinary/j2sdk-image/jre/lib/ext" -cp . Main , this test passed. Here is the result from <<grinder>>

@WilburZjh
Copy link
Contributor Author

the first test is fine, the second test that is excluded:

sun/rmi/rmic/manifestClassPath/run.sh                               https://github.com/ibmruntimes/openj9-openjdk-jdk8/issues/611   linux-x64

@WilburZjh could you give more details on why is this test failing and why should it be excluded rather then fixed?

This jvm option has been removed from other jdk versions. So Im not sure if we need to remove it as well or fix it.

@alon-sh
Copy link
Contributor

alon-sh commented Oct 13, 2022

ok you can keep it excluded. approved.

fyi @llxia @pshipton

@pshipton pshipton merged commit 33ee039 into ibmruntimes:openj9 Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants