Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermal Metrics / Temperatures #2797

Open
gtmills opened this issue Dec 7, 2020 · 10 comments
Open

Thermal Metrics / Temperatures #2797

gtmills opened this issue Dec 7, 2020 · 10 comments
Assignees
Labels
Migrate-No Do not migrate to Jira prio_high_1 ReadyForDev Stories ready for development work
Milestone

Comments

@gtmills
Copy link

gtmills commented Dec 7, 2020

Part of the new Power / Thermal

@rfrandse rfrandse added this to the A.1.204 milestone Dec 8, 2020
@gtmills
Copy link
Author

gtmills commented Jan 27, 2021

@gtmills gtmills added the ReadyForDev Stories ready for development work label Jan 29, 2021
@rfrandse rfrandse modified the milestones: A.1.204, A.1.212 Feb 19, 2021
@XiaochaoMa XiaochaoMa self-assigned this Mar 1, 2021
@ChicagoDuan
Copy link
Member

Hi @gtmills,
There's some questions. Please see the example response about TemperatureSummaryCelsiussuch in ThermalMetrics schema . how do we know the sensor name of Internal, It is different in different machines, may be it is "CPU1_Temp" or "cpu1Temp". So how do we hardcode the DataSourceUri ? Thanks.

"@odata.type": "#ThermalMetrics.v1_0_0.ThermalMetrics",
"Id": "ThermalMetrics",
"Name": "Chassis Thermal Metrics",
"TemperatureSummaryCelsius": {
    "Internal": {
        "Reading": 39,
        "DataSourceUri": "/redfish/v1/Chassis/1U/Sensors/CPU1Temp"
},
    "Intake": {
        "Reading": 24.8,
        "DataSourceUri": "/redfish/v1/Chassis/1U/Sensors/IntakeTemp"
},
    "Ambient": {
        "Reading": 22.5,
        "DataSourceUri": "/redfish/v1/Chassis/1U/Sensors/AmbientTemp"
},
    "Exhaust": {
        "Reading": 40.5,
        "DataSourceUri": "/redfish/v1/Chassis/1U/Sensors/ExhaustTemp"
}
},

@gtmills
Copy link
Author

gtmills commented Mar 3, 2021

@ChicagoDuan I think we need to discuss this with the community; we need some way to say "this is an Internal temperatureSummary sensor" or "this is an Exhaust temperatureSummarysensor" ?
Maybe associations?

@zhanghch05
Copy link

review:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/41121

@zhanghch05 zhanghch05 self-assigned this Mar 8, 2021
@mzipse mzipse modified the milestones: A.1.212, A.1.212.6 May 11, 2021
@rfrandse rfrandse modified the milestones: A.1.212.6, A.1.213.9 Jun 18, 2021
@gtmills
Copy link
Author

gtmills commented Oct 6, 2021

Can we pull this one in downstream?

@lxwinspur
Copy link

Can we pull this one in downstream?

Sure, will do

@lxwinspur
Copy link

Can we pull this one in downstream?

I checked this patch and it was pulled downstream four weeks ago.
ibm-openbmc/bmcweb@aaba73c

@gtmills
Copy link
Author

gtmills commented Oct 8, 2021

Cool. Thanks!
We use "Code Review in Driver" to mean it is downstream.

@mzipse mzipse added the Migrate-No Do not migrate to Jira label Oct 26, 2022
@gtmills
Copy link
Author

gtmills commented Dec 12, 2023

@lxwinspur
Copy link

Still need https://gerrit.openbmc.org/c/openbmc/bmcweb/+/41121

Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Migrate-No Do not migrate to Jira prio_high_1 ReadyForDev Stories ready for development work
Projects
None yet
Development

No branches or pull requests

7 participants