Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.21.2 fails to recognize windows from Zed editor #1691

Open
lily-mara opened this issue Oct 27, 2024 · 1 comment
Open

0.21.2 fails to recognize windows from Zed editor #1691

lily-mara opened this issue Oct 27, 2024 · 1 comment

Comments

@lily-mara
Copy link

lily-mara commented Oct 27, 2024

Describe the bug
After upgrading to 0.21.2 to fix #1676, I found that (inconsistently) windows from several applications would not be recognized by Amethyst. They are not resized and snapped into the grid when opened, and are not reachable using the "move focus" commands. Some applications seem more consistently un-manegable than others.

While using 0.21.0, Zed and all other applications worked perfectly fine with Amethyst. I have quit and relaunched both Amethyst and Zed several times and the issue persists. I have reboot my computer and the issue persists.

Somehow after downgrading to 0.21.0, this issue is persisting. I was quite sure that it was working with this version before upgrading, I'm not sure if something changed on my system. Originally Amethyst was installed via homebrew cask, but I switched to downloading the .app files manually from Github to do the downgrade. I don't believe anything else changed in my system since doing the amethyst upgrade this morning.

Applications:
The issue is most consistent with Zed (0.158.2) - https://zed.dev/ - seems to never get noticed by Amethyst

Also seems to happen (albeit less consistently) with Finder.

To Reproduce

  • Open a window of Zed
  • Notice it sits there in a strange spot that doesn't match Amethyst grid
  • Use Amethyst shortcut to move focus to window in the same spot as Zed
  • Zed goes behind other window, never to be seen again

Expected behavior
Amethyst should notice Zed and add it to the grid, allowing its window to be managed with keyboard shortcuts.

Screenshots

amethyst.mp4

Versions:

  • macOS: 14.7
  • Amethyst: 0.21.2

Debug Info

Version: 0.21.2 (112)

OS version: Version 14.7 (Build 23H124)

Screens:
	(0.0, 0.0, 1440.0, 900.0) [(0.0, 0.0, 1440.0, 900.0)]

Configuration:
smart-window-margins: 1
screen-padding-right: 0
use-canary-build: 0
layouts: (
    tall,
    wide,
    fullscreen,
    column
)
mod1: (
    option,
    shift
)
window-minimum-width: 0
new-windows-to-main: 0
window-margin-size: 10
enables-layout-hud: 1
screen-padding-left: 0
mod2: (
    option,
    shift,
    control
)
floating-is-blacklist: 1
restore-layouts-on-launch: 1
follow-space-thrown-windows: 1
window-resize-step: 5
window-minimum-height: 0
enables-layout-hud-on-space-change: 1
ignore-menu-bar: 0
debug-layout-info: 0
floating: (
)
float-small-windows: 1
window-max-count: 0
focus-follows-mouse: 0
mouse-follows-focus: 0
screen-padding-top: 0
window-margins: 1
screen-padding-bottom: 0

Manageable applications:
	Signal (org.whispersystems.signal-desktop)
	Firefox (org.mozilla.firefox)
	Reeder (com.reederapp.5.macOS)
	Marta (org.yanex.marta)
	Todoist (com.todoist.mac.Todoist)
	Fantastical (com.flexibits.fantastical2.mac)
	Day One (com.bloombuilt.dayone-mac)
	Finder (com.apple.finder)
	iTerm2 (com.googlecode.iterm2)
	Zed (dev.zed.Zed)

Additional context
Add any other context about the problem here.

@lily-mara lily-mara changed the title 0.21.2 fails to recognize windows from several applications 0.21.2 fails to recognize windows from Zed editor Oct 27, 2024
@lily-mara
Copy link
Author

Update: after opening new projects in Zed, I found those windows were managed correctly. Same with new windows in Finder. It's almost like there was some kind of semi-durable Window ID that predated the launch/install of Amethyst and it wasn't able to see them. The initial issue is resolved, I can manage all my windows with no issues currently, but perhaps there's a bug in the install/upgrade handling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant