Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create set of elm-review rules related to elm-units? #57

Open
ianmackenzie opened this issue Oct 21, 2020 · 1 comment
Open

Create set of elm-review rules related to elm-units? #57

ianmackenzie opened this issue Oct 21, 2020 · 1 comment

Comments

@ianmackenzie
Copy link
Owner

For use on apps/packages that use elm-units; suggest things like

  • Use Quantity.half instead of Quantity.multiplyBy 0.5 or Quantity.divideBy 2
  • Use Quantity.twice instead of Quanttiy.multiplyBy 2
@gampleman
Copy link
Contributor

Also perhaps prohibit Quantity.unwrap and Quantity.unsafe? I've unfortunately encountered these in the middle of some random application code at work, which in my mind defies the point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gampleman @ianmackenzie