From b2de151407f41a4b3b65b7adf251ea13d85d6b15 Mon Sep 17 00:00:00 2001
From: Matt Friedman <maf675@gmail.com>
Date: Thu, 15 Feb 2024 19:38:34 -0800
Subject: [PATCH] chore: update links in ABBC3 settings page to use variables
 for FAQ and external link URLs

---
 adm/style/acp_abbc3_settings.html | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/adm/style/acp_abbc3_settings.html b/adm/style/acp_abbc3_settings.html
index d7a0968f..ee85f0ea 100644
--- a/adm/style/acp_abbc3_settings.html
+++ b/adm/style/acp_abbc3_settings.html
@@ -2,8 +2,10 @@
 {% INCLUDECSS '@vse_abbc3/acp_abbc3.css' %}
 
 <img src="{{ ROOT_PATH }}ext/vse/abbc3/adm/images/abbc3logo.png" alt="{{ lang('ACP_ABBC3_MODULE') }}">
-
-<p>{{ lang('ABBC3_SETTINGS_EXPLAIN', '<a href="https://www.phpbb.com/customise/db/extension/advanced_bbcode_box/faq/1551" target="_blank">', '<i class="icon fa-external-link fa-fw" aria-hidden="true"></i></a>') }}</p>
+{% set LINK_FAQ = '<a href="https://www.phpbb.com/customise/db/extension/advanced_bbcode_box/faq/1551" target="_blank">' %}
+{% set LINK_ME_EXT = '<a href="https://www.phpbb.com/customise/db/extension/mediaembed/" target="_blank">' %}
+{% set LINK_ICON = '<i class="icon fa-external-link fa-fw" aria-hidden="true"></i></a>' %}
+<p>{{ lang('ABBC3_SETTINGS_EXPLAIN', LINK_FAQ, LINK_ICON) }}</p>
 
 <form id="abbc3_settings" method="post" action="{{ U_ACTION }}" data-ajax="true">
 	<fieldset>
@@ -46,7 +48,7 @@
 		</dl>
 		<dl>
 			<dt><label>{{ lang('ABBC3_BBVIDEO') ~ lang('COLON') }}</label><br><span>{{ lang('ABBC3_BBVIDEO_EXPLAIN') }}</span></dt>
-			<dd><span class="{{ S_ABBC3_MEDIA_EMBED ? 'success' : 'error' }}">{{ lang('ABBC3_MEDIA_EMBED_INSTALL', S_ABBC3_MEDIA_EMBED, '<a href="https://www.phpbb.com/customise/db/extension/mediaembed/" target="_blank">', '<i class="icon fa-external-link fa-fw" aria-hidden="true"></i></a>') }}</span></dd>
+			<dd><span class="{{ S_ABBC3_MEDIA_EMBED ? 'success' : 'error' }}">{{ lang('ABBC3_MEDIA_EMBED_INSTALL', S_ABBC3_MEDIA_EMBED, LINK_ME_EXT, LINK_ICON) }}</span></dd>
 		</dl>
 		<dl>
 			<dt><label for="abbc3_google_fonts">{{ lang('ABBC3_GOOGLE_FONTS') ~ lang('COLON') }}</label><br><span>{{ lang('ABBC3_GOOGLE_FONTS_INFO') }}{% if not S_ALLOW_CDN %}<br><br>{{ lang('ABBC3_GOOGLE_FONTS_NOTE') }}{% endif %}</span></dt>