Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modals and fullwidth buttons #6

Open
fbrau opened this issue Oct 5, 2018 · 2 comments
Open

modals and fullwidth buttons #6

fbrau opened this issue Oct 5, 2018 · 2 comments

Comments

@fbrau
Copy link

fbrau commented Oct 5, 2018

The library produces awesome results as it is, but what I'm missing the most are modals and fullwith buttons. Do you have these in your roadmap?

@iFallUpHill
Copy link
Owner

iFallUpHill commented Oct 5, 2018

Hey @fbrau, thanks for opening this issue!

Modals
This is a tough one as I've been experimenting with CSS-only modals a bit, but haven't found something super elegant yet. Definitely want to be working on this more for v.1.7.0 and beyond.

Full width buttons
Full width buttons were definitely something that I've been planning to work on for quite some time, and have been trying to figure out what would be the best way to approach it. I was worried that if I introduced full width class modifiers, people may want various different width denominations (e.g. 50%). If you were implementing it, what would your ideal set of class options be? (Edit: for now, have you tried using the w-100 class on your buttons? https://www.buildwithboba.com/docs/sizing.html)

Will keep you posted for both of these things as I progress.

@fbrau
Copy link
Author

fbrau commented Oct 6, 2018

The w-100 does all I want. Hadn't seen that until after posting the issue. Thanks. Maybe the docs should display a short reference to that modifier.

As for the modals, I'm not much versed in css/html stuff but have you seen the Spectree css or Bulma approaches. The Spectree modals look very natural in mobile too (bulma's not so much in my opinion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants