From 763f501ea187368ebba8e52965a6f9d057c1d7c1 Mon Sep 17 00:00:00 2001 From: gfournieriExec <100280020+gfournieriExec@users.noreply.github.com> Date: Fri, 4 Oct 2024 15:51:15 +0200 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jérémy James Toussaint <33313130+jeremyjams@users.noreply.github.com> --- .github/workflows/main.yml | 2 ++ README.md | 17 +---------------- 2 files changed, 3 insertions(+), 16 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 083ee98..cf57906 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -2,8 +2,10 @@ on: push: branches: - feature/* + - bugfix/* - develop - release/* + - hotfix/* - main jobs: diff --git a/README.md b/README.md index 181ba4b..7aa26cf 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -# iexec-voucher-contracts +iExec Voucher contracts [![codecov](https://codecov.io/github/iExecBlockchainComputing/iexec-voucher-contracts/graph/badge.svg)](https://codecov.io/github/iExecBlockchainComputing/iexec-voucher-contracts) @@ -41,21 +41,6 @@ With appropriate deployer key: ``` npx hardhat deploy --network bellecour ``` -- Logs -``` -Deploying all contracts related to voucher.. -ChainId: 134 -Using upgrader address: 0xA0C07ad0257522211c6359EC8A4EB5d21A4A1A14 -Using manager address: 0xA0C1939182b454911b78f9b087D5444d7d0E82E3 -Using minter address: 0xA0C26578F762a06c14A8153F87D0EAA2fBd036af -Using PoCo address: 0x3eca1B216A7DF1C7689aEb259fFB83ADFB894E7f -Factory: 0xfAC000a12dA42B871c0AaD5F25391aAe62958Db1 -Salt: 0x0000000000000000000000000000000000000000000000000000000000000000 -VoucherImpl: 0xf59b25A6149f1DA76470A6300aEc420540127E62 -VoucherUpgradeableBeacon: 0xFC43930c7bFb6499A692fcFC7199Ea5E68a3d9F8 -VoucherHubImpl: 0x7b5947B5e49eB2F17f35f55cB48C2a3637F7c80F -VoucherHubERC1967Proxy: 0x3137B6DF4f36D338b82260eDBB2E7bab034AFEda -``` ### Verify contracts