We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in ObsCoreMeta.from_visibility, t_xel ("Number of elements along the time axis.") is given by:
ObsCoreMeta.from_visibility
t_xel
Karabo-Pipeline/karabo/data/obscore.py
Line 545 in 420469a
According to the test, this should be 24
Karabo-Pipeline/karabo/test/test_obscore.py
Line 123 in 420469a
but if we update the test to check for 24 time steps, the test fails because t_xel is 15120
expected_timesteps = 24 if visibility.format == "OSKAR_VIS": observation = Observation(..., number_of_time_steps=expected_timesteps) ... assert ocm.t_xel is not None and ocm.t_xel == expected_timesteps
What we really want is the number of unique values in the time array. this passes:
ocm.t_xel = len(np.unique(MSMainTable.get_col(ms_path=vis_inode, col="TIME", nrow=300000000)))
I intend to fix this in an upcoming PR that also ads uvfits support.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
in
ObsCoreMeta.from_visibility
,t_xel
("Number of elements along the time axis.") is given by:Karabo-Pipeline/karabo/data/obscore.py
Line 545 in 420469a
According to the test, this should be 24
Karabo-Pipeline/karabo/test/test_obscore.py
Line 123 in 420469a
but if we update the test to check for 24 time steps, the test fails because t_xel is 15120
What we really want is the number of unique values in the time array. this passes:
I intend to fix this in an upcoming PR that also ads uvfits support.
The text was updated successfully, but these errors were encountered: