Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt codestyle using pydocstyle and mypy #304

Closed
2 tasks
Lukas113 opened this issue Feb 7, 2023 · 1 comment
Closed
2 tasks

adapt codestyle using pydocstyle and mypy #304

Lukas113 opened this issue Feb 7, 2023 · 1 comment
Assignees
@Lukas113
Labels
enhancement New feature or request prio-med Medium priority

Comments

@Lukas113
Copy link
Collaborator

Lukas113 commented Feb 7, 2023

As mentioned in #286, adapting the repository to be pydocstyle (google convention) and mypy compatible can be tedious. Therefore, It makes sense to do this file-per-file and then create a PR for almost every file.

  • code formatting
  • ci-tests

Because the process can take a while, ci-tests need to be done with exclusion. In addition, mypy needs to handle local api-usage loosely to get the checks passed.
@Lukas113 Lukas113 added enhancement New feature or request prio-med Medium priority labels Feb 7, 2023
@Lukas113 Lukas113 self-assigned this Feb 7, 2023
@Lukas113 Lukas113 mentioned this issue Feb 24, 2023
Closed
2 tasks
@Lukas113 Lukas113 mentioned this issue Apr 12, 2023
Merged
@Lukas113 Lukas113 mentioned this issue Apr 26, 2023
Merged
@Lukas113 Lukas113 mentioned this issue Jan 15, 2024
Closed
@Lukas113
Copy link
Collaborator Author

closed because duplication of #583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lukas113 Lukas113

Labels
enhancement New feature or request prio-med Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Lukas113