Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.8 Optimization Notes #22

Closed
elephunkrobitandsuch opened this issue Nov 25, 2024 · 28 comments
Closed

10.8 Optimization Notes #22

elephunkrobitandsuch opened this issue Nov 25, 2024 · 28 comments

Comments

@elephunkrobitandsuch
Copy link

elephunkrobitandsuch commented Nov 25, 2024

Not an issue, but 3 optimizations I've had success with on Intel machines running 10.8.5:

  1. Sometimes when typing in the address bar or other input fields, the first letter is invisible, and then appears after the second letter is typed. This is fixed by going into about:config and setting "layers.acceleration.disabled" to "TRUE"

  2. Printing was causing a crash. This was resolved by changing "print.prefer_system_dialog" to TRUE

  3. Gmail web browser has a few oddities, which are resolved by going into about:config and doing a "general.useragent.override" and change the useragent to coincide with your OS. For example, running Mountain Lion I changed it from "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:133.0) Gecko/20100101 Firefox/133.0" to Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5; rv:133.0) Gecko/20100101 Firefox/133.0"

**And just an added thank you to i3roly for his amazing work on this project.

@Wowfunhappy
Copy link

Wowfunhappy commented Nov 28, 2024

Gmail web browser has a few oddities, which are resolved by going into about:config and doing a "general.useragent.override" and change the useragent to coincide with your OS. For example, running Mountain Lion I changed it from "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:133.0) Gecko/20100101 Firefox/133.0" to Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5; rv:133.0) Gecko/20100101 Firefox/133.0"

Wat.

I wonder what is happening on gmail's side for this to work. There must be some legacy code in gmail from a decade ago which was originally added to workaround a bug in Firefox under Mountain Lion—and apparently when modern Firefox is back-ported to Mountain Lion it still hits that bug! But, Google's workaround is still present in gmail's code, if you activate it by changing the user agent.

I have nothing productive to add, I just think this situation is absolutely wild! Wow!

Note that AIUI all major browsers have frozen the user agent string for privacy reasons, ie if you're using upstream Firefox on any version of macOS (whether newer or older than macOS Catalina), the OS in your user agent string will be "Intel Mac OS X 10.15". So, the right solution is probably not for Firefox Dynasty to break from that policy and list the real operating system. But, maybe there could be a WebCompat add-on. There are already lots of UA overrides built into Firefox: https://github.com/mozilla-extensions/webcompat-addon/blob/main/src/data/ua_overrides.js

@RJVB
Copy link

RJVB commented Nov 28, 2024 via email

@Wowfunhappy
Copy link

Disclosing your OS version is a privacy concern nowadays?

It's fingerprinting related.

I can't seem to find any Firefox-centric announcements but here is one for Chrome, I assume Firefox is going down a similar path here. https://developers.google.com/privacy-sandbox/blog/user-agent-reduction-android-model-and-version

@i3roly
Copy link
Owner

i3roly commented Dec 5, 2024

this should be fixed in the next release.

@i3roly
Copy link
Owner

i3roly commented Dec 6, 2024

i will be uploading 1340b7 shortly here, and it should address the problem you're speaking of.

please try it and report back afterwards. note: it should behave as the developers intended, and nothing more. i acknowledge the agent string deviated from source, which was sort of an accident from a naive early attempt at trying to port the source.

but after i ported it properly i kept that change since i thought it was neat, but it might cause issues with certain sites if they're expecting agent representation that's exactly 10.15, which is what the main source does.

@elephunkrobitandsuch
Copy link
Author

You are a god among insects.

@elephunkrobitandsuch
Copy link
Author

All 3 issues remain with 1340b7, but they are also all mitigated by the workarounds posted above. The exception is (1), where the first letter typed is invisible. With the update, the "layers.acceleration.disabled" to "TRUE" tag no longer fixes this issue on 10.8.5

@i3roly
Copy link
Owner

i3roly commented Dec 6, 2024

i test stuff in VMs, so i can't say whether i'd be able to reproduce your issues.
disabling layers acceleration sounds like it's related to graphics. i thought you had an issue with the agent, but now it's in-line with the mainline:

https://github.com/i3roly/firefox-dynasty/blob/beta/browser/components/resistfingerprinting/test/browser/browser_navigator.js

so i can't explain why the third issue exists. if it's to do with the agent alone, then this is a mainline problem as well.

@elephunkrobitandsuch
Copy link
Author

I wouldn't waste any time worrying about it. The three about:configs get it working beautifully, so I just wanted to post that here in case anyone else runs into the same issues.

This project is amazing, and I am so thankful that you have undertaken it!

@i3roly
Copy link
Owner

i3roly commented Dec 6, 2024

the printing issue is related to a symbol i'll look into that.

@RJVB
Copy link

RJVB commented Dec 6, 2024 via email

@i3roly
Copy link
Owner

i3roly commented Dec 6, 2024

if it's just modifying a preference by default, then i don't think that's the answer.

i am kind of surprised though, now that you mention it, that some extra work is required for this.

i know on the official build both of the "signatures.required" features are set false by default, so what can we do?

@RJVB
Copy link

RJVB commented Dec 6, 2024 via email

@i3roly
Copy link
Owner

i3roly commented Dec 6, 2024

that flag should work. i'll put it in the next build when i get this cups symbol crap fixed.

@i3roly
Copy link
Owner

i3roly commented Dec 6, 2024

fixed the cups issue and tested on 10.7 (which still needs one fix that is annoying the fuck out of me)

Screen.Recording.2024-12-06.at.11.39.37.AM.mp4

this was a sub 10.9 issue. thanks for bringing it to my attention.

pushing an updated b07 with the signing disabled for extensions and also this fix. lmk

with respect ot this text field layer glitch, i'm curious as to what graphics card you're using? i know the firefox team had some hacks for different cards and if yours is among them. i tried to include those fixes but maybe they're causing problems here.

@RJVB
Copy link

RJVB commented Dec 6, 2024 via email

@i3roly
Copy link
Owner

i3roly commented Dec 6, 2024

try it out

@RJVB
Copy link

RJVB commented Dec 6, 2024 via email

@RJVB
Copy link

RJVB commented Dec 6, 2024

OK, so 134.0b7 works fine on 10.9.5 but I can still not get a self-built, unsigned extension to work that does work with the Developer Edition on Linux. Bummer!

@i3roly
Copy link
Owner

i3roly commented Dec 6, 2024

can you provide a link to such an extension so i can see what's going on?

@RJVB
Copy link

RJVB commented Dec 6, 2024

@i3roly
Copy link
Owner

i3roly commented Dec 6, 2024

"looking into it" xD

@RJVB
Copy link

RJVB commented Dec 6, 2024 via email

@i3roly
Copy link
Owner

i3roly commented Dec 7, 2024

you will have to enable the flags shown in the video, but the next release i'm pushing in a little bit should allow unsigned extensions.

not as trivial as originally thought, but it's done.

Screen.Recording.2024-12-06.at.5.45.41.PM.mp4

@i3roly
Copy link
Owner

i3roly commented Dec 7, 2024

@RJVB the updated 1340b7 with this adjustment is now available. make sure to reset your profile and test again. i know i had to do that to ensure it worked. you may not have to if you're migrating from an older version.

@RJVB
Copy link

RJVB commented Dec 7, 2024

you will have to enable the flags shown in the video, but the next release i'm pushing in a little bit should allow unsigned extensions.

You mean xpinstall.signatures.required and extensions.langpacks.signatures.required, right? I did unset the former (required on Linux too) but probably not the latter since I wasn't installing an unsigned language pack. I also unset xpinstall.whitelist.required just in case. Having to unset one or more of these is intended AFAIK.

I'll test the new build and let you know. I appreciate the efforts!

@RJVB
Copy link

RJVB commented Dec 7, 2024 via email

@i3roly
Copy link
Owner

i3roly commented Jan 1, 2025

this will have to be closed. sorry @elephunkrobitandsuch. i think it's your graphics card causing the issues in 10.8. i can't do much about that.

i have fixed the printing issue, and the gmail oddity (that you apparently fixed through modification of the user agent) is not caused by my changes since i have restored it to the mainline version.

@i3roly i3roly closed this as completed Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants