Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop Out Video → Full Screen → Exit Full Screen (via OS X menu bar) leads to invisible video. #18

Closed
Wowfunhappy opened this issue Oct 27, 2024 · 8 comments

Comments

@Wowfunhappy
Copy link

Wowfunhappy commented Oct 27, 2024

To reproduce:

  1. Open a Youtube video (or likely almost any video), such as https://www.youtube.com/watch?v=WO2b03Zdu4Q
  2. Click the "pop out video" icon.
  3. Click the Fullscreen icon in the bottom right corner.
  4. Exit full Screen by:
    1. Hovering your mouse at the top of your monitor to unhide the OS X menu bar, then clicking the icon in the top right corner to exit full screen.
    2. Pressing the esc key.
    • Do not click Firefox's "exit full screen" button in the bottom right corner, which won't trigger the bug.

The video will disappear. The tab will say "the video is playing in Picture-in-Picture" mode, and sound will be audible, but there's no window to be seen.

Additionally, if you follow steps 1–3, then switch back to the space which contains your Firefox window while the PiP video is still full screen, the PiP will display over the Firefox window and everything else. I'm not actually sure what the expected behavior is here—I'd hope it's just "let the video keep playing in its own full screen space and don't interfere with other spaces" except Mozilla and I don't always agree—but it clearly shouldn't do this.

You can "fix" these problems by setting full-screen-api.macos-native-full-screen to false in about:config. However, you loose some potentially nice OS X integration in the process.

Tested on 10.9.5. I'm on my main system rather than a VM, but I can test in a clean VM if you really think it's system specific.

@i3roly
Copy link
Owner

i3roly commented Dec 26, 2024

i know this is fixed in the latest central.

seems it uses spaces implicitly on older macs

Screen.Recording.2024-12-26.at.1.35.36.PM.mp4

@RJVB
Copy link

RJVB commented Dec 26, 2024

seems it uses spaces implicitly on older macs

You mean newer OS versions no longer have that extremely annoying obligatory feature where your other displays will go black if you fullscreen an app on one display with "displays have separate spaces" not set?

@Wowfunhappy
Copy link
Author

Wowfunhappy commented Dec 29, 2024

@i3roly In your video, I don't think you're exiting fullscreen the right way to trigger the bug. You need to use OS X's icon, not Firefox's. Hovering your mouse at the top of your (virtual) monitor to unhide the OS X menu bar, then click the icon in the top right corner.

@i3roly
Copy link
Owner

i3roly commented Dec 29, 2024

i pressed the escape key in one of them, and the 'x' button on the other. so the escape key worked.
and i just did what you asked and it works evne better than using the 'esc' key or clicking the x button (two versions i showed in the previous video):

Screen.Recording.2024-12-29.at.10.56.06.AM.mp4

@Wowfunhappy
Copy link
Author

Huh, yes it did work there! I'm using the test build for #26 from a few days ago which I thought was based on central. Odd, I did try this in a clean VM...

@Wowfunhappy
Copy link
Author

Okay, this is actually a difference between 10.8 and 10.9. (It looks like you were testing in 10.8 from your video).

Only 10.9 has the bug when you exit fullscreen via the OS X icon. 10.8 works fine.

Both 10.8 and 10.9 do have the secondary oddity where if you fullscreen the PiP window, then switch back to your main space, the PiP window will appear in front of everything. As I said, I don't actually know for sure what the expected behavior is here, but I really hope it's not this!!!

I tested https://github.com/i3roly/firefox-dynasty/releases/tag/fuckaround in 10.8 and 10.9 VMs open side by side.

@i3roly
Copy link
Owner

i3roly commented Dec 29, 2024

i don't even know how well spaces are supported in VMs, but maybe it's totally native. i'm not sure.

personally i won't be fixing this because i don't care about it.

sorry

@Wowfunhappy
Copy link
Author

Fair enough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants