Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When val_data is None, it breaks checkpoint saving #72

Open
andresespinosapc opened this issue Jan 13, 2020 · 0 comments
Open

When val_data is None, it breaks checkpoint saving #72

andresespinosapc opened this issue Jan 13, 2020 · 0 comments

Comments

@andresespinosapc
Copy link

It is possible to set val_data to None in SupervisedTrainer.train, and it is handled (for example in CallbackContainer._evaluate_model_on_validation). But, if I set val_data to None, the total_loss in Callback.get_losses is never calculated, so checkpoints are never saved in CallbackContainer.on_batch_end.

So, you should (1) log a warning saying that dev_data should not be None, or (2) handle checkpoint saving in another way when there is no dev_data (such as saving last checkpoints instead of the ones with best loss values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant