Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorings for TPC-H and span-based data structures #118

Open
2 of 4 tasks
phoeinx opened this issue Feb 27, 2023 · 0 comments
Open
2 of 4 tasks

Refactorings for TPC-H and span-based data structures #118

phoeinx opened this issue Feb 27, 2023 · 0 comments

Comments

@phoeinx
Copy link
Collaborator

phoeinx commented Feb 27, 2023

Tracking issue for everything that needs to be adapted to allow for a clean(-ish) mmap-based TPC-H run:

Functional

  • [TPC-H 09]: Doesn't run through due to issue in for-based range loop over dictionary -> FixedStringSpanIterator seems to have a bug.
  • [TPC-H 11]: Somehow only works when run once, not when run twice?

Major

  • [Byte* Map]: We currently store our map as a uint32_t* (due to legacy reasons). This means that we can only access it in four-byte steps, making padding every written section to four byte divisible byte lengths necessary. It should be possible and easier to store the map as a byte* and cast as necessary.

Formschön

  • [Stream instead of Filename]: Make things pretty like in BinaryWriter and don't pass file_name but a file_stream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant