-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For discussion, NO MERGE : Dispatcher v2 API 1st proposition #394
Draft
johnr14
wants to merge
18
commits into
hyprwm:main
Choose a base branch
from
johnr14:dispatcher_v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some fixes
lowercase 1 letter
some more fix
last changes before squash
Please view as a wiki-page for now. Thanks If you know how I could squash this, please tell. |
fix a few typos
Param added fakefullscreen as it's in windows rules. Added missing commas in examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current API of dispatcher is not optimal, it's not uniform, uses too many types of different actions and has poor predictability for function's name.
Left unchanged, it is a irritant to new user and will get worse with time if the complexity of hyprland keeps growing in a far future. Those changes can be postponed, but having a API revision after release 1.0 wouldn't be the best.
As no names where kept and thus no collision with previous API occurs, this could be implemented without breaking anything.
Old API could be discouraged and eventually be deprecated and removed after a notice and appropriate elapsed time.
The term
window
is deprecated in favor ofclient
as Wayland namely use clients. However Wayland does interchange the termwindow
andclient
a lot in it's documentation but it says this about it's architecture : "is how clients actually render under wayland", "the rendering happens in the client, and the client just sends a request to the compositor to indicate the region that was updated ", "the compositor receives generic Wayland buffers from the clients". Could revert to windows if maintainers or users strongly wish for it.This proposition is an attempt to consolidate the wording used in the dispatcher's functions name with a naming convention that :
All names are in a format of :
nounVerbVariation
.The number of dispatchers action verbs went down from 22 to 9.
Lots of param where defined. Params use the
opt:param
syntax, may or may not be kept depending on difficulty to implement.A few examples are added for groups and special workspace.
Discussed in #3805
First proposition, please check for :
This is in no way implemented in bind or hyprctl and is used to illustrate how the API could be redesigned.
Thanks for your time in pondering on how to make hyprland even greater and please add your comments. I did try to finish in a rush and may have made a few "oops". I'll try to squash the request, hope it works.