Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme issues #1

Open
TheSunCat opened this issue Dec 15, 2023 · 8 comments
Open

Theme issues #1

TheSunCat opened this issue Dec 15, 2023 · 8 comments

Comments

@TheSunCat
Copy link

This app is a great idea! Hope to see this implemented within Hyprland in the future :)

Using the catppuccin theme through Kvantum, the interface has some major issues unfortunately.

image

  1. Logo gets cut off
  2. Text does not fit in the view and is not scrollable
  3. The tabs appear clickable (they change when you hover over them), but do not seem to do anything
  4. Buttons are missing padding and have inconsistent height. The text does not fit in some of them
@vaxerski
Copy link
Member

check now

@TheSunCat
Copy link
Author

image

Appreciate the back button!

  1. Logo still gets cut off
  2. The view is now scrollable (though there is no visual indication of this, I just had to guess).
  3. Tabs still communicate that they are clickable but clicking does nothing.
  4. One of the buttons still gets cut off.

@vaxerski
Copy link
Member

yeah idk why 1 happens
2 is the result of your theme

@vaxerski
Copy link
Member

4 should be fixed

@TheSunCat
Copy link
Author

image

Looking good! So the remaining ones are:

  • Tabs change on hover indicating they are clickable, but clicking them does nothing.
  • Logo gets cut off

A small design issue, I'm not sure about having the exit buttons at the bottom right. That's where I'd naturally gravitate to click to advance a dialog, and I almost accidentally hit the exit button. Can they be placed elsewhere (top right, bottom left).

Also, the last slide encourages checking the wiki, while not having any action buttons to actually go there. I'd have to go back to the Configuring slide to get to the wiki, which is not ideal.

Also, if there is no .desktop file, users might not know they need to type HyprlandWelcome to launch it. I think styling this as monospaced would help, and indicating you need to type it into a prompt would be best.

@vaxerski
Copy link
Member

I have no clue why the logo gets cut off.
Tabs changing color is an issue with your theme. I don't think there is a way to disable just the tabs, though. Feel free to let me know if you know of one.

@Deeepkk1
Copy link

@TheSunCat are you directly applying theme with kvantum ? or using qt5ct/qt6ct

@TheSunCat
Copy link
Author

It's going through Kvantum. I don't really understand how these themes work, though some Qt apps are severely broken with the way it's set up (KDE apps have dark text on a dark background). I have QT_QPA_PLATFORMTHEME=qt5ct and kvantum-dark set as the theme in qt5ct and qt6ct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants