Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update URLs in README #1001

Merged
merged 2 commits into from
Nov 30, 2024
Merged

update URLs in README #1001

merged 2 commits into from
Nov 30, 2024

Conversation

qupo1
Copy link
Contributor

@qupo1 qupo1 commented Nov 17, 2024

No description provided.

Copy link
Contributor

@bertm bertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version of Gradle is a moving target, and the link may break when the documentation structure changes. Please link to the actual version that is used (currently 8.9, after #996 it will be 8.11).

@qupo1
Copy link
Contributor Author

qupo1 commented Nov 18, 2024

The current version of Gradle is a moving target, and the link may break when the documentation structure changes. Please link to the actual version that is used (currently 8.9, after #996 it will be 8.11).

Thank you for review! I updated PullRequest.
Please merge this after #996, because this PR uses 8.11 docs.

Copy link
Contributor

@ArneBab ArneBab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me — thank you!

Merging before #996 because while that’s still in review, the URLs are valid and #996 just waits for validation that the fix is OK and the link changes in the readme are useful right away, not only at release.

@ArneBab ArneBab merged commit eec4ef1 into hyphanet:next Nov 30, 2024
1 check passed
@qupo1 qupo1 deleted the readme-links branch December 1, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants