feat(pollux): add credential abstraction #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goncalo-frade-iohk
force-pushed
the
feature/ZKP-Abstraction
branch
from
b13f899
to
520e8f8
Compare
curtis-h
reviewed
Jun 30, 2023
| import Foundation | ||
|
|
||
| /// `ProofableCredential` is a protocol that adds provability functionality to a credential. | ||
| public protocol ProofableCredential { |
There was a problem hiding this comment.
not sure about this naming, "Proofable" is not a meaningful term, perhaps "ProvableCredential" or "ProofCredential" would be more suitable?
There was a problem hiding this comment.
Yeah not sure as well. Im ok with changing, although I would prefer the ProvableCredential since it's a protocol/interface/abstraction I prefer it not to be a noun.
In my opinion:
In the case of ProofCredential as Proof is a noun it relays that the Credential itself is a Proof.
But ProvableCredential is more in line with the concept that it creates a proof given a context.
But tell me what you think @curtis-h around this?
There was a problem hiding this comment.
I like your thinking, let's go with ProvableCredential then :)
cristianIOHK
approved these changes
Jul 3, 2023
goncalo-frade-iohk
force-pushed
the
feature/ZKP-Abstraction
branch
from
520e8f8
to
ad02957
Compare
ATL-4786 Besides adding the new credential abstraction this adds the following: - Changes on Pollux to use the new abstraction - Changes on PrismAgent to use new abstraction - Changes on Sample App to for new abstraction - Adds tests for new implementation - Adds Codable to Messages - Updates error codes and documentation - Updates all documentation on new methods
goncalo-frade-iohk
force-pushed
the
feature/ZKP-Abstraction
branch
from
ad02957
to
148186e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATL-4786
Besides adding the new credential abstraction this adds the following: