-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable peer.deliveryclient.blockGossipEnabled in sample core.yaml #3961
Comments
Moving to Fabric v3.0... in Fabric v3.0 either this default will be changed or the gossip block dissemination function will be entirely removed... see proposal in hyperledger/fabric-rfcs#49. |
Will newly joined nodes be affected when they perform block synchronization? |
denyeart
added a commit
to denyeart/fabric
that referenced
this issue
Jun 25, 2024
Since v2.2 it has been recommended to configure all peers to be orgLeaders so that they pull blocks from ordering service. In v2.4 peer.deliveryclient.blockGossipEnabled was added and recommended to be set to false so that peers don't gossip pulled blocks. These settings simplify peer behavior and reduce communication between peers (at the expense of more connections to ordering service). Finally in v3.0 peer.deliveryclient.blockGossipEnabled is set to false by default. This change also updates core.yaml and documentation to make these recommendations clear and consistent. Closes hyperledger#3961 Signed-off-by: David Enyeart <[email protected]>
denyeart
added a commit
to denyeart/fabric
that referenced
this issue
Jun 26, 2024
Since v2.2 it has been recommended to configure all peers to be orgLeaders so that they pull blocks from ordering service. In v2.4 peer.deliveryclient.blockGossipEnabled was added and recommended to be set to false so that peers don't gossip pulled blocks. These settings simplify peer behavior and reduce communication between peers (at the expense of more connections to ordering service). Finally in v3.0 peer.deliveryclient.blockGossipEnabled is set to false by default. This change also updates core.yaml and documentation to make these recommendations clear and consistent. Closes hyperledger#3961 Signed-off-by: David Enyeart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the release note of v2.5.0, under "FAB-15317: Block dissemination via gossip is deprecated", the recommended setting for
blockGossipEnabled
isfalse
. I think sampleconfig/core.yaml should reflect that.The text was updated successfully, but these errors were encountered: