Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OrdererEndpoints in test-network's bft sample #1085

Conversation

satota2
Copy link
Contributor

@satota2 satota2 commented Aug 29, 2023

This patch fixes the description of orderer2-4 in OrdererEndpoints in test-network's bft-config/configtx.yaml.

Details

I noticed that the current configuration in the configtx.yaml file lists all endpoints under "orderer.example.com" with different port numbers. I wonder if the orderer names should be distinct, such as 'orderer2.example.com', 'orderer3.example.com', and 'orderer4.example.com', each with their respective port numbers.

Check for problems and their fixes

I commented out the first entry of orderer.example.com:7050 temporarily to see if peers have trouble pulling blocks from the other endpoints as shown in the following log.

$ docker logs peer0.org1.example.com
...
2023-08-29 05:12:55.161 UTC 005b WARN [peer.blocksprovider] DeliverBlocks -> Could not connect to ordering service: could not dial endpoint 'orderer.example.com:7056': failed to create new connection: connection error: desc = "transport: error while dialing: dial tcp 172.20.0.7:7056: connect: connection refused" channel=mychannel
2023-08-29 05:12:55.161 UTC 005c WARN [peer.blocksprovider] DeliverBlocks -> Disconnected from ordering service. Attempt to re-connect in 4.6s channel=mychannel

After that, I tested by fixing the hostname of orderer2-4 and validated that fix solves the problem as shown in the following log.

$ docker logs peer0.org1.example.com
...
2023-08-29 05:18:35.155 UTC 0031 INFO [peer.blocksprovider] Start -> BlockReceiver starting channel=mychannel orderer-address=orderer2.example.com:7052

This patch fixes the description of orderer2-4 in OrdererEndpoints
in test-network's bft-config/configtx.yaml.

Signed-off-by: Tatsuya Sato <[email protected]>
@satota2 satota2 requested a review from a team as a code owner August 29, 2023 08:27
@satota2
Copy link
Contributor Author

satota2 commented Aug 29, 2023

Hi @arkadiPiven, I've created a PR based on your original work. As the original author, do you agree with the changes?

Copy link
Contributor

@arkadiPiven arkadiPiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the correct way to input OrdererEndpoints. Thank you for noticing.

Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @satota2

@denyeart denyeart merged commit f2c1c59 into hyperledger:main Aug 29, 2023
29 of 41 checks passed
@satota2
Copy link
Contributor Author

satota2 commented Aug 29, 2023

@arkadiPiven Thank you for your confirmation.
@denyeart Thank you for the quick merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants