Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onchain checkpoint syncer, contract sdk #4659

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: onchain checkpoint syncer, contract sdk #4659

wants to merge 7 commits into from

Conversation

NOOMA-42
Copy link
Contributor

@NOOMA-42 NOOMA-42 commented Oct 10, 2024 •
edited
Loading

Description

enable validator to submit checkpoints on-chain

Drive-by changes

add onchain checkpoint interface

Related issues

Backward compatibility

Yes

Testing

Run EvmCheckpoint.hardhat-test.ts by running yarn test:hardhat in typescript sdk

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: daeb619

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

yorhodes
yorhodes reviewed Dec 2, 2024
View reviewed changes
solidity/contracts/libs/CheckpointLib.sol Outdated Show resolved Hide resolved
solidity/contracts/CheckpointStorage.sol Outdated Show resolved Hide resolved
solidity/contracts/CheckpointStorage.sol Outdated Show resolved Hide resolved
@NOOMA-42 NOOMA-42 force-pushed the feat-onchain-checkpoint-syncer branch from a9bf645 to 840fad4 Compare December 4, 2024 12:02
@NOOMA-42 NOOMA-42 changed the title feat: onchain checkpoint feat: onchain checkpoint syncer, contract sdk Dec 4, 2024
@NOOMA-42 NOOMA-42 marked this pull request as ready for review December 4, 2024 12:06
@NOOMA-42 NOOMA-42 mentioned this pull request Dec 4, 2024
Draft
@NOOMA-42 NOOMA-42 force-pushed the feat-onchain-checkpoint-syncer branch from 4246d1f to daeb619 Compare December 10, 2024 15:08
@NOOMA-42
Copy link
Contributor Author

@yorhodes I've updated with your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorhodes yorhodes yorhodes left review comments

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@paulbalaji paulbalaji Awaiting requested review from paulbalaji paulbalaji is a code owner

@Mo-Hussain Mo-Hussain Awaiting requested review from Mo-Hussain Mo-Hussain is a code owner

@jmrossy jmrossy Awaiting requested review from jmrossy jmrossy is a code owner

@ltyu ltyu Awaiting requested review from ltyu ltyu is a code owner

@daniel-savu daniel-savu Awaiting requested review from daniel-savu daniel-savu is a code owner

@aroralanuk aroralanuk Awaiting requested review from aroralanuk aroralanuk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validator should be able to be configured submit checkpoints on-chain
2 participants
@NOOMA-42 @yorhodes