Wrong encoded ids for some features

[zbycz]

Hi,

we have integrated OpenFreeMap in osmapp.org, but there is an issue with type encoded in the id field in the MVT tiles. The last number in the id should encode 0=node, 1=way and 4=relation.

Example

1. If I click on Prague while changed to OpenFreeMap layer – eg. here: osmapp.org#8.60/50.06/14.63
2. I see in DevTools it has id 16018379311
   
3. It is decoded as 1->way, thus way/1601837931, and osmapp brings us to this URL osmapp.org/way/1601837931
4. same issue is with almost all active POIs on the map.

Expected result:
In reality it is a node, so it should end with 0. If we use the default layer Basic from Maptiler, it works correctly.

.

Relevant issues / related code:

Maptiler also had a long time issues with wrong encoding IDs, I believe they were using openmaptiles internally, but later switched to thier own impl (planetiler?) and that needed fixes to the id encoding too.

• example in openmaptiles sql (may be wrong)
• encoder/decoder in typescript in osmapp
• original (fixed) issue in imposm
• openmaptiles issue – Maptiler managed to fix it in their prod server, but probably not in openmaptiles code.
• possibly relevant planetiler issue with links to PRs

(same issue in indoor= stack: indoorequal/indoorequal#49)

[hyperknot]

Luckily it's a single change, OFM uses planetiler and planetiler uses this system

Yep that's the new behavior as of #826 - the vector tile feature IDs are osm ID * 10 + {1 for OSM nodes, 2 for OSM ways, 3 for OSM relations, 0 for any other source} so you can tell whether the feature came from a node, way or relation. You can set --feature-source-id-multiplier=false if you want to disable the behavior and just set vector tile feature IDs to the original ID of the osm element.

onthegomap/planetiler#1042 (comment)

Can you open an issue in planetiler to change the system to from 123 to 124?

[zbycz]

Thanks @hyperknot! I added the issue here onthegomap/planetiler#1120 🤞

[hyperknot]

Great and really detailed issue! I'd mention that you are planning to use it for osmapp.org, which is a very impressive project!