-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebTransport: stream priority #197
Comments
Accessing the underlying stream could easily lead to issues when invariants are being broken due to a user reading or writing or in other ways modifying the code, which mechanisms in I think a similar mechanism as the I am willing to tackle this, though I think it is up to the owners of |
In the design proposal was a RFC mentioned about prioritization.
I am not familiar with the RFC so I can not tell at the moment if this also works with Web-Transport or if it fits your use-case. About the types maybe we can introduce a associated type at the |
I brought up HTTP/3 priorities because it's a standard and has to be implemented at the QUIC layer. See this recent blog post for more info about RFC9218. WebTransport prioritization is completely separate from HTTP/3 prioritization but ideally should share an implementation. The urgency field in HTTP/3 priorities is basically the WebTransport's proposed send order, but constrained to a u3 (8 values) instead of a i32. The incremental field in HTTP/3 priorities it hard-coded to I've been chatting with @LPardue about adding And keep in mind that any form of WebTransport/MoQ prioritization scheme could change. I am confident that some form of strict prioritization is the right solution, but the API is still very much up in the air. There's also a lot of small details being worked out, like the policy towards retransmissions. That's why I would argue for a per-implementation API until we're further along to stabilize a trait. |
Hey folks,
I'm working on a proposed live media standard: Media over QUIC. I ported my library from quiche to quinn when I found the
h3-webtransport
crate. Big thanks to @darioalessandro and @ten3roberts for implementing it!One thing that got lost in my migration was the ability to prioritize streams. It's critically important for MoQ and it's the key functionality that allows QUIC to deliver live media over congested networks. I specifically want send order, which means streams are transmitted in a strict order based on an integer priority (basically a priority queue).
Quinn implements send order but it is not implemented in the h3::quic trait or the h3_webtransport::SendStream struct. One of the problems is that there's no official QUIC API and nothing is sent over the wire, so stream prioritization is up to the implementation. Here's a few I've seen in the wild:
I think there's two routes to support stream prioritization.
1. Add
set_priority
to theh3::quic
trait.The debate would primarily be over the API. I'm a huge fan of a
i32
(like Quinn) to match the JS API, but that would rule out other QUIC backends as they exist today.I could work with a
u8
like I did with quiche, but it's quite annoying. My application would maintain the stream priority queue and constantly update the stream priority with the index in the queue, limited to 256 streams outstanding at any time. Alternatively, I've discussed changing the quiche API with the authors and they're open to it.I don't think an incremental flag is useful, even for the HTTP/3 Priorities.
incremental=false
is a solid default.2. Add a mechanism to access the underlying SendStream.
The
h3::quic
trait makes a lot of sense for HTTP/3 since there's a set of core functionality required for HTTP/3. However, WebTransport models itself as QUIC on the web, which means exposing a nebulous "QUIC API". You can envision WebTransport as a thin layer on top of QUIC streams primarily for browser support.I think it would be reasonable if the application could access the
quinn::SendStream
directly. For those unaware, WebTransport streams involve a few bytes at the start to identify thesession_id
. They behave like regular QUIC streams after that, although RESET_STREAM error codes use a special encoding to include thesession_id
.I haven't explored if this would work, but maybe
h3_webtransport::SendStream
could implementinner(&mut self) &mut T
or justDerefMut
? It would be ideal if the application could not get access to the underlyingquinn::SendStream.reset()
to avoid misuse, which is why overloading it and usingDeref
might be better, but I think theh3::quic
trait gets in the way.The text was updated successfully, but these errors were encountered: