Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable RCF in the JVM during CLJS build (in :require-macros scenario) #67

Open
dustingetz opened this issue Sep 21, 2022 · 2 comments
Open

Comments

@dustingetz
Copy link
Member

dustingetz commented Sep 21, 2022

When the CLJ REPL and Shadow are sharing JVM, RCF tests are enabled at the CLJ repl and Shadow needs to disable JVM RCF tests during incremental builds because :require-macros in a CLJS file will cause the CLJ files to load, running tests if enabled.

https://shadow-cljs.github.io/docs/UsersGuide.html#compile-stages

(defn rcf-shadow-hook 
  {:shadow.build/stage #{:configure :flush}}
  [build-state & args]
  (case (:shadow.build/stage build-state)
    :configure (enable! false)
    :flush (enable!))
  build-state)
@dustingetz dustingetz changed the title Disable RCF in the JVM during CLJS build (in CLJC scenario) Disable RCF in the JVM during CLJS build (in :require-macros scenario) Sep 21, 2022
@dustingetz
Copy link
Member Author

I am running with this patch locally for a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant