Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider native support for unixsockets #1138

Open
JCoder01 opened this issue Mar 2, 2024 · 1 comment
Open

Consider native support for unixsockets #1138

JCoder01 opened this issue Mar 2, 2024 · 1 comment
Labels
adapters related to the Adapter system enhancement a new feature or addition

Comments

@JCoder01
Copy link

JCoder01 commented Mar 2, 2024

Usage outlined here works great, except the maintainer of requests_unixsocket seems to be MIA. There hasn't been any updates for 2+ years and it isn't compatible with urllib3 v2 released last year.

@briantist briantist added enhancement a new feature or addition adapters related to the Adapter system labels Apr 15, 2024
@briantist
Copy link
Contributor

Hi @JCoder01 , it looks like there has been a fix for a while but as you said the maintainer is MIA even for transferring ownership and there might be a few published forks with the fix but it also doesn't seem like any have real dedicated maintainers either

I am not sure how much we want to do natively for this in the project. If a stable library comes out I would consider adding an extras entry for pulling the package in, but that doesn't really help the current situation.


I think the way this is best (potentially) handled at the moment is via a custom hvac adapter class. I would also possibly consider accepting that, but unfortunately I think our Adapter system needs an overhaul and it's been difficult to find the time. Here's something I was working on a while ago (not unixsocket related):


I have also considered the possibility of vendoring some packages in some capacity, for example our tests for LDAP rely on an abandoned LDAP test server project also waiting on a fix that will probably never be merged or published. But I can't take vendoring lightly and given how little time I have available to dedicate to this project already I'm not sure it would be a good idea.


Happy to discuss ways forward; in the meantime, looking at one of the published forks is probably the easiest short-term solution for your own uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters related to the Adapter system enhancement a new feature or addition
Projects
None yet
Development

No branches or pull requests

2 participants