Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to release shared memory on python side with rollback #78

Open
Flunzmas opened this issue Dec 20, 2022 · 0 comments
Open

Option to release shared memory on python side with rollback #78

Flunzmas opened this issue Dec 20, 2022 · 0 comments

Comments

@Flunzmas
Copy link

Hey there,

in the file py_interface.py, both Ns3AIDL and Ns3AIRL define ReleaseAndRollback(). From my understanding, this enables unlocking the memory without yielding control to the other side (useful for sequential read accesses on the python side, just like you could use GetCompleted() on the C++ side for a release with rollback). However, the __exit__() method of these two classes uses Release() only.

Would it make sense to extend the context manager implementation by allowing to release with rollback, e.g. to enable sequential read accesses on the same side? So far I have implemented a simple workaround via a method SetRollbackOnRelease() on my local branch (see here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant