Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove c-style casts from codebase #342

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Remove c-style casts from codebase #342

merged 3 commits into from
Nov 8, 2024

Conversation

jazonshou
Copy link
Contributor

Not sure if I got all of them but I think I got most

huttongrabiel
huttongrabiel approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@huttongrabiel huttongrabiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful. sorry for the mundane pr but it looks like you got the hang of interacting with the code base

@huttongrabiel
Copy link
Contributor

Also, there is merge conflicts so you'll have to handle those and then commit again. After than I can approve and merge :)

@jazonshou jazonshou merged commit cc5e422 into master Nov 8, 2024
3 checks passed
@jazonshou jazonshou deleted the remove-c-style-casts branch November 8, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huttongrabiel huttongrabiel huttongrabiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jazonshou @huttongrabiel