Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The icons of the toggle dark and light mode in the docs and also the sample implementation is inverted. #892

Closed
SaiedWork opened this issue Mar 11, 2024 · 1 comment
Labels
type: documentation A change or addition to the documentation

Comments

@SaiedWork
Copy link

Change Type

Correction

Proposed Changes

When a website is currently in light mode, the icon that should be visible is typically the moon icon. This is because the moon icon represents dark mode, and clicking it would switch the website to dark mode. It’s a common practice in user interface design to display the icon of the mode that can be switched to, not the mode that is currently active. So in light mode, you see a moon (for dark mode), and in dark mode, you see a sun (for light mode). The original shadcn-ui docs page has also the icons inverted. The rotate transitions also not working. For example the bits-ui docs page has the correct toggle behavior and the transitions are also working.
However at the end, it's a design decisions. Saying that just in case of user friendliness.

@SaiedWork SaiedWork added the type: documentation A change or addition to the documentation label Mar 11, 2024
@huntabyte
Copy link
Owner

We'll update this if also updated at https://ui.shadcn.com, which we are trying to remain aligned with 😃

@huntabyte huntabyte closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A change or addition to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants