Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed hosts array will contain one empty string item if no option set #97

Open
roborourke opened this issue Jan 16, 2025 · 0 comments

Comments

@roborourke
Copy link
Contributor

array_map( 'trim', explode( ',', Admin\get_sso_settings( 'sso_whitelisted_hosts' ) ) );

Will resolve to [ '' ] if no hosts have been added to the list. We maybe also should have at least the main or current site URL as an allowed host. This is based on the derived redirect value, so really we just want to prevent redirecting outside of the WP site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant