Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL-encoded file names break source sets #71

Open
sweber83 opened this issue Jan 7, 2022 · 0 comments
Open

URL-encoded file names break source sets #71

sweber83 opened this issue Jan 7, 2022 · 0 comments

Comments

@sweber83
Copy link

sweber83 commented Jan 7, 2022

When the tachyon plugin url encodes file names, wp_get_attachment_image_srcset() always returns false.
This is the case because wp_calculate_image_srcset() compares the plain file name with the url encoded url, which never results in a match.

I tried fixing the problem by url encoding the file names, too, but this leads to new problems.
What I see as a possible solution, is to not encode the file names at all.
This can be achieved by reverting 256b67e & 5db2683
I tried this in my branch here, and it seems to work fine.

I'm not really sure, if this creates any new problems.
There's another issue #23, which also has problems with the url encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant