Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include previously registered sizes in filter_image_downsize() #52

Open
peterwilsoncc opened this issue Dec 29, 2019 · 0 comments
Open

Comments

@peterwilsoncc
Copy link
Contributor

The downsizing filter uses Tachyon::image_sizes() to determine valid sizes for an image to account for image sizes registered after an image was uploaded.

If registered sizes were removed after an image was uploaded, the legacy size will be referenced in wp_get_attachment_metadata( $attachment_id )['sizes']. To account for these, the downsize and content filters should combine both the meta sizes with registered sizes.

Design decision: should a clash exist between the legacy and current image size names, which version should be deferred to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant