New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow taxonomies with publicly_queryable=true to be used as a filter #11

Open

ocean90 opened this issue Jan 8, 2025 · 0 comments · May be fixed by #12

ocean90 commented Jan 8, 2025 •

edited

Loading

Currently only taxonomies which are public=true can be added as a filter:

query-filter/src/taxonomy/edit.js

Line 18 in 366f064

).filter( ( taxonomy ) => taxonomy.visibility.public );

I think the proper check would be publicly_queryable=true just like the editor uses in various cases, see https://github.com/search?q=repo%3AWordPress%2Fgutenberg%20publicly_queryable&type=code. This allows to have non-public but still publicly queryable taxonomies to be used as a filter. Happy to provide a PR if there are no objections.

The text was updated successfully, but these errors were encountered:

ocean90 linked a pull request

that will close this issue

Allow to select all publicly queryable taxonomies #12

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment