Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image rename command #93

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Add image rename command #93

merged 2 commits into from
Dec 4, 2020

Conversation

roborourke
Copy link
Contributor

This command is a migration tool for making images in the media library compatible with Tachyon.

Addresses #30

This command is a migration tool for making images in the media library compatible with Tachyon.

Addresses #30
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Left a comment about the --search-replace param. I'd like a bit more clarity around that because, afaict, the entire script/cli command is itself a search/replace command, so it's unclear to me what that parameter actually does that's different from the default behavior.


- `--network` if present will run the process for all sites on the network.
- `--sites-page` allows you to change the current page of sites. 100 sites will be processed at a time so if you have more you will need to run the command again for each page of sites.
- `--search-replace` if present will perform a database search and replace process for the updated image names.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from the default behavior? Would you pass specific items to search for and replace to this param (e.g. to limit the rename process to a specific batch or naming pattern)? (If so, perhaps a bit of clarity in the docco might be useful along with an example usage.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, if the implication is that the database rename doesn't actually happen unless this parameter is passed, that should be noted in the description above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images themselves and the attachment data is always updated, the --search-replace parameter controls whether or not the rest of the database is checked and updated.

I'll call this out specifically in the preamble.

@roborourke roborourke merged commit 08bcd88 into master Dec 4, 2020
@roborourke roborourke deleted the add-image-renaming-command branch December 4, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants