Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream bug in Tachyon leads to 404s #30

Closed
1 task
joehoyle opened this issue Jun 17, 2019 · 5 comments
Closed
1 task

Upstream bug in Tachyon leads to 404s #30

joehoyle opened this issue Jun 17, 2019 · 5 comments
Assignees
@roborourke
Labels
bug Existing functionality isn't behaving as expected must have Must be done, high priority

Comments

@joehoyle
Copy link
Member

joehoyle commented Jun 17, 2019 •
edited by roborourke
Loading

humanmade/tachyon-plugin#43

Acceptance criteria:

  • Images with names like image-300x300.jpg can be uploaded and processed successfully by tachyon
@joehoyle joehoyle added the bug Existing functionality isn't behaving as expected label Jun 17, 2019
@joehoyle joehoyle added this to the 2.0 Beta milestone Jun 17, 2019
@joehoyle joehoyle removed this from the 2.0 Beta milestone Jul 9, 2019
@joehoyle
Copy link
Member Author

joehoyle commented Jul 9, 2019

This isn't going to make it in v2 I think.

@elodiebouneau elodiebouneau modified the milestones: 3.0, 4.0 Oct 15, 2019
@roborourke
Copy link
Contributor

roborourke commented Dec 4, 2019 •
edited
Loading

For this we could perhaps detect that pattern in file names on upload and strip the dimensions before saving to disk.

@roborourke roborourke removed this from the 4.0 milestone Jan 28, 2020
@roborourke roborourke self-assigned this Nov 3, 2020
@roborourke
Copy link
Contributor

Got a PR for a CLI migration command here humanmade/tachyon-plugin#63

@roborourke roborourke added the must have Must be done, high priority label Nov 18, 2020
roborourke added a commit that referenced this issue Dec 3, 2020
@roborourke
Add image rename command
fa10df7 
This command is a migration tool for making images in the media library compatible with Tachyon.

Addresses #30
@roborourke roborourke mentioned this issue Dec 3, 2020
Merged
@roborourke
Copy link
Contributor

Taken a different approach here and providing a migration command directly with Altis. See #93

@roborourke
Copy link
Contributor

Going to close this issue out as we have a solution now. It is being handled separately for affected clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roborourke roborourke

Labels
bug Existing functionality isn't behaving as expected must have Must be done, high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roborourke @joehoyle @elodiebouneau