Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Sign Ups UI and terminology #100

Open
rmccue opened this issue Sep 17, 2019 · 3 comments
Open

Rework Sign Ups UI and terminology #100

rmccue opened this issue Sep 17, 2019 · 3 comments
Labels
could have Could be done, or nice to have, low priority for now

Comments

@rmccue
Copy link
Member

rmccue commented Sep 17, 2019

"Sign Ups" is the internal name for this stuff really, it shouldn't be exposed to users. We should move this under the "Users" menu, and consider renaming.

Possible alternative names:

  • Pending Invitations
  • Unconfirmed Users

We should also consider removing the "Add New" page, or combining it with the existing "Users > Add New" page.

@elodiebouneau elodiebouneau added this to the 4.0 milestone Oct 15, 2019
@roborourke roborourke assigned rmccue and jazzsequence and unassigned rmccue Jan 28, 2020
@rmccue
Copy link
Member Author

rmccue commented Jan 28, 2020

The way signups works is pretty confusing, and mostly makes sense for a massive multisite install like WordPress.com. Long-term, we might want to look at skipping this process entirely for the sorts of sites that Altis is used for, but in the meantime we can at least clarify the UI.

When you add a user to a multisite instance, you're actually inviting them to join the site. WordPress creates an entry in the signups table to register this invitation, and the invitation is converted to a real user when they accept.

To clarify this flow, we should do the following:

  • Remove the "Add New" page under signups, as it duplicates the regular user creation pages
  • Rename Signups to "Invitations" everywhere it's used
  • On the user creation page, clarify that a user invitation will be sent, and will be visible in the invitations page (this is linked to the "send email to user" checkbox, which is unclear currently)

This may require changes to the upstream signups plugin we're using to implement this functionality currently.

As a stretch goal, we should look at whether we can redesign the user creation screen in a similar way to #93 to be much clearer about what actions will take place and which action a user should perform.

@rmccue
Copy link
Member Author

rmccue commented Jan 28, 2020

(Also, it may be worth considering copying some of the changes I made to the Altis Central auth signup process. Ping me in Slack for more details.)

@jazzsequence
Copy link
Contributor

I got as far as I could on this trying to just use existing WordPress hooks to move and rename the Sign ups page into the Users menu in #187. It needs more work but it's a start.

@jazzsequence jazzsequence removed their assignment Jan 31, 2020
@rmccue rmccue modified the milestones: 4.0, 5.0 Jun 12, 2020
@rmccue rmccue removed this from the 5.0 milestone Sep 2, 2020
@PriyaBhatia0210 PriyaBhatia0210 added the could have Could be done, or nice to have, low priority for now label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could have Could be done, or nice to have, low priority for now
Projects
None yet
Development

No branches or pull requests

7 participants