Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the argument in submission_tmpl() be hub_path instead of hub_con? #165

Open
annakrystalli opened this issue Nov 20, 2024 · 0 comments

Comments

@annakrystalli
Copy link
Member

Currently there is an option to provide either a hub_connection class object to hub_con, which has config_tasks attached as an attribute) or a config class object to config_tasks. It feels easier to just ask for hub_path instead of requiring folks to use hubData::connect_hub() to create a hub_connection given we only need the actual config_tasks object from the connection.

I would suggest we just do away with config_tasks (which also requires an extra step to read the config) and restrict the argument to hub_path only, then use read_config() internally to get the config.

This would also resolve #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Wishlist
Development

No branches or pull requests

1 participant