Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider re-wording non-decreasing value column check message #143

Open
lshandross opened this issue Oct 29, 2024 · 1 comment
Open

Consider re-wording non-decreasing value column check message #143

lshandross opened this issue Oct 29, 2024 · 1 comment

Comments

@lshandross
Copy link

Currently the message printed for the non-descending value column check is quite long:

✔ [value_col_non_desc]: Values in `value` column are non-decreasing as output_type_ids increase for all unique task ID value/output type combinations of quantile or cdf output types

It would be clearer if we moved the part about the check only being for quantile and cdf output types to the beginning, as well as prevent misunderstandings if the last part of the message is cut off (or people don't read that far)

@zkamvar
Copy link
Member

zkamvar commented Oct 30, 2024

I'm wondering if we should just take the title of the check documentation: "quantile and cdf output type values of model output data are non-descending"

Or maybe "quantile and cdf output type values of model output data do not decrease"

We can then add more context if there is an error: "quantile and cdf output type values of model output decrease. Values should not decrease with increasing output_type_id values"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants