Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discontinue use of tissue_sample_types.yaml #653

Closed
kburke opened this issue Mar 29, 2023 · 2 comments
Closed

Discontinue use of tissue_sample_types.yaml #653

kburke opened this issue Mar 29, 2023 · 2 comments
Assignees
@kburke
Labels
P Pitt dev team

Comments

@kburke
Copy link

kburke commented Mar 29, 2023 •
edited
Loading

Where a 'display_subtype' is assigned to an ElasticSearch document for non-organ Samples, discontinue use of the tissue_sample_types.yaml file. Replace with a capitalized of the sample_category, which should cover Block, Suspension, and Section.

See also files-api#43
See also search-api#723
@kburke kburke added the P Pitt dev team label Nov 20, 2023
@kburke kburke changed the title Use organ & assay type code explanations from ontology service Use organ & assay type code explanations from UBKG Nov 20, 2023
@kburke kburke mentioned this issue Nov 20, 2023
Closed
@yuanzhou yuanzhou mentioned this issue Dec 12, 2023
Closed
@kburke kburke changed the title Use organ & assay type code explanations from UBKG Use organ type code explanations from UBKG, discontinue use of tissue_sample_types.yaml Dec 13, 2023
@kburke
Copy link
Author

kburke commented Dec 13, 2023 •
edited
Loading

search-adaptor/pull/50
search-api/pull/728

@yuanzhou
Copy link
Member

yuanzhou commented Jan 8, 2024

#723

@kburke kburke changed the title Use organ type code explanations from UBKG, discontinue use of tissue_sample_types.yaml Discontinue use of tissue_sample_types.yaml Jan 8, 2024
@shirey shirey closed this as completed Jan 9, 2024
@shirey shirey added this to Pitt HIVE Jun 7, 2024
@shirey shirey moved this to Done in Pitt HIVE Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kburke kburke

Labels
P Pitt dev team
Projects
Pitt HIVE
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yuanzhou @kburke @shirey