You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Joel has a concern that the reporting scripts rely on particular patterns in the validation report: It would be better if the report could just be parsed as YAML. I don't want to change the validation report first, because that would break the downstream script, so a multi-step process instead:
In ingest-pipeline, change the script to just look for No errors anywhere in the first line.
Changes are made in ingest-validation-tools, and a follow-up issue is filed in ingest-pipeline
ingest-pipeline is updated to parse the report as JSON.
This is not a high-priority for me, but I think it would address Joel's concerns.
Context:
The software that generates the table of unpublished datasets looks for validation_report.txt in the top level directory, and declares the dataset to have been validated if that file is present and starts with 'No Errors'. This feature is pretty obsolete now that data is usually provided in the form of Uploads, so it could be disabled. If the desired solution is to modify that first line, an issue should be created in ingest-pipeline to disable this check.
Joel has a concern that the reporting scripts rely on particular patterns in the validation report: It would be better if the report could just be parsed as YAML. I don't want to change the validation report first, because that would break the downstream script, so a multi-step process instead:
ingest-pipeline
, change the script to just look forNo errors
anywhere in the first line.No errors: True
(ie, valid YAML)ingest-validation-tools
, and a follow-up issue is filed iningest-pipeline
ingest-pipeline
is updated to parse the report as JSON.This is not a high-priority for me, but I think it would address Joel's concerns.
Context:
Originally posted by @jswelling in hubmapconsortium/ingest-validation-tools#1099 (comment)
The text was updated successfully, but these errors were encountered: