Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24 hr event page updates #810

Merged
merged 6 commits into from
Nov 15, 2024
Merged

24 hr event page updates #810

merged 6 commits into from
Nov 15, 2024

Conversation

edlu77
Copy link
Contributor

@edlu77 edlu77 commented Nov 12, 2024

No description provided.

@edlu77 edlu77 requested review from bherr2 and LibbyUX November 12, 2024 07:53
@edlu77 edlu77 self-assigned this Nov 12, 2024
Copy link

nx-cloud bot commented Nov 12, 2024

Copy link

github-actions bot commented Nov 12, 2024

🚀 Preview Deploy Report Updated

✅ Successfully deployed preview here

@LibbyUX
Copy link
Contributor

LibbyUX commented Nov 12, 2024

Good morning @bherr2 & @edlu77, thanks for making this happen so quickly!

I see Katy wants to review this now per the ongoing email thread. I'm going to wait to approve these changes until we have her approval.

Can one of you please send me the URL to this preview page? I am having trouble locating it after going to the HRA Portal and the old event page from 2022. I'd like to share it with her, if possible. Thanks!

@LibbyUX
Copy link
Contributor

LibbyUX commented Nov 12, 2024

Hi @edlu77, I have a request for this UI now that I see it here:
https://67330a328fc5ee75aae666e2--hra-ui.netlify.app/apps/humanatlas.io/events/2024-24h/

Is it possible to remove the borders for the images? I believe it would look better and be more on brand without the borders/strokes around the circular images.

image

@edlu77
Copy link
Contributor Author

edlu77 commented Nov 12, 2024

@LibbyUX Border has been removed! Let me know if anything else comes up.

@edlu77
Copy link
Contributor Author

edlu77 commented Nov 12, 2024

@LibbyUX Link to new preview: https://673397be06b89f20f5809721--hra-ui.netlify.app/apps/humanatlas.io/events/2024-24h/

(For future reference you can access the page if you add "events/2024-24h" at the end of the preview url)

@LibbyUX
Copy link
Contributor

LibbyUX commented Nov 13, 2024

@edlu77 Thanks so much - It looks great on my end! This design/build is likely going to be more iterative with the content still being situated. I emailed Katy/team with the preview link and image board tonight making sure to CC you. Talk soon and have a lovely evening!

@edlu77 edlu77 requested a review from axdanbol November 15, 2024 01:16
Copy link

sonarcloud bot commented Nov 15, 2024

@bherr2 bherr2 merged commit ba5621a into main Nov 15, 2024
9 checks passed
@bherr2 bherr2 deleted the 24-hr-event-page-updates branch November 15, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants