This repository has been archived by the owner on Sep 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
Truncate Regex Causes Infinite Loop #24
Comments
Wanted to bump this because its still an issue and another component I want to use relies on this library. |
I'm actually experiencing this issue as well. A block of HTML I'm trying to truncate contains a Vimeo video embed and has attributes with no value so it's causing the process to lock up. :-( |
Hello @huang47, do you plan any updates? Thank you. |
Same issue, there is any solution? |
same.. any solution? |
And seems like it still does, hangs on HTML with 3 P and one nested IMG P.S. Surprising ppl still trying to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This commit adds no value attributes to the truncation process but also introduces an infinite loop. Running this regex: KEY_VALUE_REGEX = '([\w|-]+\s*(=\s*"[^"]")?\s)*' on an iframe with attributes with and without values will result in the process freezing. For example, this bit of code will result in the process locking:
<iframe width="560" height="315" src="//www.youtube.com/embed/eFGolAT2l6c" frameborder="0" allowfullscreen></iframe>
The specific line that freezes is 205:
selfClose = SELF_CLOSE_REGEX.exec(result);
This error can be reproduced by executing that line of code, having set the pertinent values, on the command line. I've also written a test to demonstrate the problem on this branch:
master...jbasdf:locking_bug
The text was updated successfully, but these errors were encountered: