Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic file I/O with Uproot -> Opening the file -> skhep_testdata module #48

Open
JacekHoleczek opened this issue Aug 4, 2023 · 3 comments
Labels

Comments

@JacekHoleczek
Copy link
Contributor

JacekHoleczek commented Aug 4, 2023

In the "Basic file I/O with Uproot" chapter, in the "Opening the file" section, you unconditionally "import skhep_testdata".
However, "standalone" users who installed the full "scikit-hep" will not have this module.
I'd like to propose to add in this place a small:
Note: you may need to run "conda/mamba/pip install scikit-hep-testdata" in order to have this module.
Or maybe simply:
import skhep_testdata # you may first need to run conda/mamba/pip install scikit-hep-testdata

@jpivarski
Copy link
Collaborator

It's included in

@JacekHoleczek
Copy link
Contributor Author

Sorry, I was not clear enough.

I am trying to go through the tutorial as a "newcomer" would.
So, as someone who only installed either "uproot", or "scipy", or "sckit-hep".
I can't rely on one finding/consulting/applying the additional tutorial's requirements.txt file from git.

In general, I expect from Python that whenever one gets a "No module named 'AddOn'" error, one needs to "conda/mamba/pip install AddOn".
If that is not the case, I think it would be nice to add an explicit note in the tutorial that some magic "conda/mamba/pip install Module" provides the required "AddOn".

That's the case for "skhep_testdata" which needs "scikit-hep-testdata".

@stale
Copy link

stale bot commented Oct 4, 2023

This issue or pull request has been automatically marked as stale because it has not had recent activity. Please manually close it, if it is no longer relevant, or ask for help or support to help getting it unstuck. Let me bring this to the attention of @klieret @wdconinc @michmx for now.

@stale stale bot added the stale label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants