Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the examples? #317

Open
SomeRandomGuy009 opened this issue Aug 10, 2022 · 8 comments
Open

Rewrite the examples? #317

SomeRandomGuy009 opened this issue Aug 10, 2022 · 8 comments

Comments

@SomeRandomGuy009
Copy link

People coming across this project are mostly beginners or people who don't know how to code. But, they want to test out the agents and battle them.
Most of the example code doesn't work , one of which is stated in #314

@SomeRandomGuy009 SomeRandomGuy009 changed the title Rewrite the examples Rewrite the examples? Aug 10, 2022
@mancho2000
Copy link

Thanks for this. Being one of them, I would also appreciate if there could be more examples. Like using other libraries, self play, etc would be very nice

@akashsara
Copy link
Contributor

I've submitted a new version of selfplay on #322 but I'm curious as to which other example code doesn't work. I could take a look at it if you can point it out

@SomeRandomGuy009
Copy link
Author

I've submitted a new version of selfplay on #322 but I'm curious as to which other example code doesn't work. I could take a look at it if you can point it out

pretty sure openai ones don't work too

@akashsara
Copy link
Contributor

akashsara commented Aug 26, 2022

If you pip installed poke-env, rl_with_open_ai_gym_wrapper.py should work. If you installed it directly from Github, rl_with_new_open_ai_gym_wrapper.py. Could you confirm which version of poke-env you have and which script you tried?

Edit: A new release went out a couple of hours ago, so the pip installed version and the Github version should be the same. Do a pip install poke-env and try running rl_with_new_open_ai_gym_wrapper.py?

@SomeRandomGuy009
Copy link
Author

ill try and let you know soon

@SomeRandomGuy009
Copy link
Author

SomeRandomGuy009 commented Aug 30, 2022

If you pip installed poke-env, rl_with_open_ai_gym_wrapper.py should work. If you installed it directly from Github, rl_with_new_open_ai_gym_wrapper.py. Could you confirm which version of poke-env you have and which script you tried?

Edit: A new release went out a couple of hours ago, so the pip installed version and the Github version should be the same. Do a pip install poke-env and try running rl_with_new_open_ai_gym_wrapper.py?

i did try the new open ai gym wrapper agent but:

ModuleNotFoundError: No module named 'poke_env.abstract_battle'

poke-env version: 0.5.0
Operating System: Ubuntu 20.04 and Ubuntu 18.04

@akashsara
Copy link
Contributor

akashsara commented Aug 31, 2022

Oh I think I see the issue. Try using from poke_env.environment import AbstractBattle instead of from poke_env.abstract_battle import AbstractBattle.

@SomeRandomGuy009
Copy link
Author

Oh I think I see the issue. Try using from poke_env.environment import AbstractBattle instead of from poke_env.abstract_battle import AbstractBattle.

yep, did that yesterday and started working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants