Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deletion of simulated region now cascades #740

Merged
merged 9 commits into from
Mar 10, 2023
Merged

Fix deletion of simulated region now cascades #740

merged 9 commits into from
Mar 10, 2023

Conversation

benn02
Copy link
Contributor

@benn02 benn02 commented Mar 9, 2023

No description provided.

@benn02 benn02 linked an issue Mar 9, 2023 that may be closed by this pull request
Bug: Deletion of simulated region does not cascade #712
Open
@benn02 benn02 self-assigned this Mar 9, 2023
@benn02 benn02 added bug Something isn't working shared Issues mainly related to shared labels Mar 9, 2023
@lukasrad02 lukasrad02 self-requested a review March 10, 2023 10:06
@benn02 benn02 requested a review from lukasrad02 March 10, 2023 11:57
lukasrad02
lukasrad02 reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@lukasrad02 lukasrad02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just add this change to the CHANGELOG.md and I'll be fine with it

@benn02 benn02 enabled auto-merge (squash) March 10, 2023 14:02
@benn02 benn02 merged commit 41e9cb3 into dev Mar 10, 2023
@lukasrad02 lukasrad02 deleted the fix/712-bug-deletion-of-simulated-region-does-not-cascade branch March 10, 2023 14:18
Nils1729 added a commit that referenced this pull request Mar 11, 2023
@Nils1729
Revert "Fix deletion of simulated region now cascades (#740)"
7b91763 
This reverts commit 41e9cb3.
Nils1729 added a commit that referenced this pull request Mar 13, 2023
@Nils1729
Hotfix/revert 740 cascade deletion of simulated regions (#750)
1006e8b 
* Revert "Fix deletion of simulated region now cascades (#740)"

This reverts commit 41e9cb3.

* Bump version to 0.2.1
Nils1729 added a commit that referenced this pull request Mar 17, 2023
@Nils1729 @Greenscreen23
Hotfix/revert 740 cascade deletion of simulated regions (#750) (#766)
e3b343a 
* Revert "Fix deletion of simulated region now cascades (#740)"

This reverts commit 41e9cb3.

* Bump version to 0.2.1

Co-authored-by: Lukas Hagen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasrad02 lukasrad02 lukasrad02 approved these changes

Assignees

@benn02 benn02

Labels
bug Something isn't working shared Issues mainly related to shared
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Deletion of simulated region does not cascade
2 participants
@benn02 @lukasrad02