Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't drop the original message on parsing stats #96

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

wdpypere
Copy link
Contributor

@wdpypere wdpypere commented Oct 31, 2024

the current setup drops the nagios message if there was one, and replaces it by the statistic name. so it might be

msg = "failed in service nrpe" 
stats= {'fail': 1}

and it will return just fail as a message.
The only place where I see this function being used correctly is in service_sanity. other uses just dance around it and do checking themselves. (which is wrong, but another discussion)

In fact, it does this for OK values, but not for failed values, which is counterintuitive.

@stdweird stdweird merged commit 7041b46 into hpcugent:master Oct 31, 2024
3 checks passed
@wdpypere wdpypere deleted the nagios_result branch October 31, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants